+1

On 26/11/2018 02:56, Alexey Ivanov wrote:
Hi Dmitry,

The fix looks fine to me.

Regards,
Alexey

On 26/11/2018 10:38, Dmitry Markov wrote:
Hello,

Could you review a fix for jdk12, please?

bug: https://bugs.openjdk.java.net/browse/JDK-8213583
webrev: http://cr.openjdk.java.net/~dmarkov/8213583/webrev.00/

Problem description:
On Windows when a SecurityManager is defined and JFileChooser is opened for the 
folder which contains a broken shortcut the system popup message is displayed. 
The current implementation of ShellFolder for Windows calls 
IShellLinkW::Resolve without any flags. So the appearance of the dialog with 
system message for the broken shortcut is quite expected, see 
https://docs.microsoft.com/en-us/windows/desktop/api/shobjidl_core/nf-shobjidl_core-ishelllinkw-resolve

Fix:
It is necessary to use SLR_NO_UI flag to suppress any system dialogs during 
IShellLinkW::Resolve invocation.

Thanks,
Dmitry



--
Best regards, Sergey.

Reply via email to