+1 Thanks, Krishna
> On 06-Dec-2018, at 2:29 PM, Dmitry Markov <dmitry.mar...@oracle.com> wrote: > > Thank you, Sergey! > Looking for the second “+1” from someone else. > > Thanks, > Dmitry > >> On 6 Dec 2018, at 00:10, Sergey Bylokhov <sergey.bylok...@oracle.com> wrote: >> >> Looks fine. >> >> On 30/11/2018 01:53, Dmitry Markov wrote: >>> Hi Sergey, >>> The occurrence of the problem does not depend on child windows, their type >>> and visibility. The issue is caused by orderFront operation when it is >>> called for the focused window, (i.e. window which is already located above >>> other windows). In other words double invocation of order operation for the >>> same window will break cycling shortcut. >>> I have updated the fix, see >>> http://cr.openjdk.java.net/~dmarkov/8213983/webrev.03/ >>> Changes summary: >>> - Added check to suppress ordering if the window is already active, (i.e. >>> owns focus) >>> - Backed out the changes made under JDK-8206392 [1] since they are not >>> necessary anymore >>> I have verified that the test for JDK-8206392 still works properly with my >>> fix. >>> Thanks, >>> Dmitry >>> [1] - https://bugs.openjdk.java.net/browse/JDK-8206392 >>>> On 28 Nov 2018, at 21:09, Sergey Bylokhov <sergey.bylok...@oracle.com >>>> <mailto:sergey.bylok...@oracle.com>> wrote: >>>> >>>> Hi, Dmitry. >>>> >>>> Can you please clarify why the invisible children affect this behavior? >>>> Is it possible that some of the invisible child(which we skip after the >>>> fix) will have visible child window? >>>> >>>> On 22/11/2018 06:43, Dmitry Markov wrote: >>>>> Hi Sergey, >>>>> I am sorry, but the problem is not related to popup windows at all. >>>>> Actually the root cause of the issue is that we perform ordering >>>>> operation for the window which has only invisible child windows. I have >>>>> updated the fix: http://cr.openjdk.java.net/~dmarkov/8213983/webrev.02/ >>>>> Could you review the new version, please? >>>>> Thanks, >>>>> Dmitry >>>>>> On 21 Nov 2018, at 23:22, Sergey Bylokhov <sergey.bylok...@oracle.com >>>>>> <mailto:sergey.bylok...@oracle.com> <mailto:sergey.bylok...@oracle.com>> >>>>>> wrote: >>>>>> >>>>>> On 21/11/2018 12:51, Dmitry Markov wrote: >>>>>>> When we are going to display the popup, all related windows, (i.e. the >>>>>>> owner, its child windows and their child an so on) are already ordered. >>>>>>> They were ordered once the owner received focus. >>>>>> >>>>>> I guess it is always true if the user click on the window >>>>>> and popup was shown, but how it will work if the popup window >>>>>> was shown programmatically without making window focused? >>>>>> >>>>>> >>>>>> -- >>>>>> Best regards, Sergey. >>>> >>>> >>>> -- >>>> Best regards, Sergey. >> >> >> -- >> Best regards, Sergey. >
