Hi All,

 

Please review a fix for JDK-8215921: 
https://bugs.openjdk.java.net/browse/JDK-8215921,

Webrev: http://cr.openjdk.java.net/~kaddepalli/8215921/webrev00/

 

This is a regression, which involves other similar bugs HYPERLINK 
"https://bugs.openjdk.java.net/browse/JDK-8215942"JDK-8215942, HYPERLINK 
"https://bugs.openjdk.java.net/browse/JDK-8215920"JDK-8215920, HYPERLINK 
"https://bugs.openjdk.java.net/browse/JDK-8215918"JDK-8215918. 
The problem happens only in linux, wherein the ItemStateChanged event is not 
posted, when a mouse click happens on a particular item in Choice. 
This was introduced because of the fix of HYPERLINK 
"https://bugs.openjdk.java.net/browse/JDK-8014503"JDK-8014503. 

While fixing HYPERLINK 
"https://bugs.openjdk.java.net/browse/JDK-8014503"JDK-8014503, the check for 
newly selected index and the currently selected index was applied wherever 
there was a postEvent for the same. However, for the case of mouseRelease, the 
check is already performed since it tracks two things already - dragStartId and 
newIdx, and posts an event only if both are not same.

 
I have added a new testcase which checks for the mouse event clicked on a 
different item. This test was not present earlier, which made it harder to 
detect this.

 

I have run the jtreg tests and did not find any new failures, and also verified 
that the newly introduced test case passes on Windows, Linux and Mac.

 

Thanks,

Krishna

Reply via email to