Hi Sergey, I think you need to add "@run main" command and this bug id to the "@bug" list of bugs. Also you can update the copyright year to this year as well.
Thanks and regards, Shashi -----Original Message----- From: Dmitry Markov Sent: Thursday, March 7, 2019 2:59 PM To: Sergey Bylokhov <sergey.bylok...@oracle.com> Cc: awt-dev@openjdk.java.net Subject: Re: <AWT Dev> [13] Review Request: 8219504 Test for JDK-8211435 can be run on all platforms Hi Sergey, The fix looks good to me. Thanks, Dmitry > On 7 Mar 2019, at 06:59, Sergey Bylokhov <sergey.bylok...@oracle.com> wrote: > > Thank you for review! > Looking for the second +1 from someone else. > > On 20/02/2019 22:20, Krishna Addepalli wrote: >> +1 >> Krishna >> -----Original Message----- >> From: Sergey Bylokhov >> Sent: Thursday, February 21, 2019 8:01 AM >> To: awt-dev@openjdk.java.net >> Subject: <AWT Dev> [13] Review Request: 8219504 Test for JDK-8211435 >> can be run on all platforms Hello. >> Please review the fix for jdk 13. >> Bug: https://bugs.openjdk.java.net/browse/JDK-8219504 >> Fix: http://cr.openjdk.java.net/~serb/8219504/webrev.00 >> Currently the test for JDK-8211435 is executed on macOS only, because of >> JDK-8204142[1][2]: >> But since JDK-8204142 was fixed we can run it on all platforms. >> [1] https://bugs.openjdk.java.net/browse/JDK-8204142 >> [2] >> http://mail.openjdk.java.net/pipermail/awt-dev/2018-October/014492.ht >> ml > > > -- > Best regards, Sergey.
