Looks OK.
-phil.
On 7/18/19, 6:01 AM, Baesken, Matthias wrote:
Hello, please review this very small fix .
Currently we assign NULL two times in gtk2_interface.c to gint values.
This leads to warning like this (xlc16 / clang) :
/jdk/src/java.desktop/unix/native/libawt_xawt/awt/gtk2_interface.c:2454:10:
warning: incompatible pointer to integer conversion initializing
'gint' (aka 'int') with an expression of type 'void *' [-Wint-conversion]
gint intval = NULL;
^ ~~~~
/jdk/src/java.desktop/unix/native/libawt_xawt/awt/gtk2_interface.c:2461:10:
warning: incompatible pointer to integer conversion initializing
'gint' (aka 'int') with an expression of type 'void *' [-Wint-conversion]
gint intval = NULL;
^ ~~~~
Bug/webrev :
https://bugs.openjdk.java.net/browse/JDK-8228368
http://cr.openjdk.java.net/~mbaesken/webrevs/8228368.0/
<http://cr.openjdk.java.net/%7Embaesken/webrevs/8228368.0/>
Thanks, Matthias