Hi Matthias,
looks good to me.
Maybe you want to create a Macro for the repeating pattern:
graphicsConfigs[ind] = ZALLOC (_AwtGraphicsConfigData);
if (graphicsConfigs[ind] == NULL) {
JNU_ThrowOutOfMemoryError(env, "allocation in getAllConfigs failed");
goto cleanup;
}
in getAllConfigs?
Best regards
Christoph
From: 2d-dev <[email protected]> On Behalf Of Baesken, Matthias
Sent: Mittwoch, 25. September 2019 09:40
To: [email protected]; [email protected]
Subject: [CAUTION] [OpenJDK 2D-Dev] RFR [XS]: 8231445: check ZALLOC return
values in awt coding
Hello, please review this small fix . It deals with return value checking of
ZALLOC .
ZALLOC is a macro using calloc, please see :
jdk/src/java.desktop/unix/native/common/awt/awt_p.h
/* allocated and initialize a structure */
#define ZALLOC(T) ((struct T *)calloc(1, sizeof(struct T)))
... so the return value has to be checked which is missing at some places.
Bug/webrev :
https://bugs.openjdk.java.net/browse/JDK-8231445
http://cr.openjdk.java.net/~mbaesken/webrevs/8231445.0/
Thanks, Matthias
