Hello Sergey, The product changes look good. Do we need to add separate test in open? It should be possible to move the closed test mentioned in bug to open after cleanup as it is checking both edit/print operation for both file and a directory.
Regards, Pankaj -----Original Message----- From: Sergey Bylokhov Sent: Monday, March 23, 2020 3:02 PM To: awt-dev@openjdk.java.net Subject: <AWT Dev> RFR: 7131400 [macosx] Desktop.edit(a directory) should throw IOException Hello. Please review the fix for jdk/client. Bug: https://bugs.openjdk.java.net/browse/JDK-7131400 Fix: http://cr.openjdk.java.net/~serb/7131400/webrev.00 The java.awt.Desktop.edit()/print() methods behave differently on macOS and Windows when the folder is passed as a parameter. On Windows we throw IOException, and on macOS we open the folder using Finder. This change aligns behavior and always throws an exception. On linux these methods are not implemented and throw UnsupportedOperationException. -- Best regards, Sergey.
