On Thu, 29 Oct 2020 13:14:49 GMT, Jayashree S Kumar 
<github.com+31532647+jay...@openjdk.org> wrote:

> Issue
> 
> https://bugs.openjdk.java.net/browse/JDK-8244088
> 
> Problem
> 
> While using GTK3 java implementation,  User sees a deadlock issue in UI while 
> trying to switch themes in gnome-tweak-tool.

src/java.desktop/unix/native/libawt_xawt/awt/swing_GTKEngine.c line 353:

> 351:         JNIEnv *env, jobject this)
> 352: {
> 353:     // Note that gtk->flush_event_loop takes care of locks (7053002)

Different people used these methods (gdk_threads_enter/gdk_threads_leave) here 
twice which caused two regressions. Looks like the comment about locks is not 
enough. Could you please update the comment and state that 
gdk_threads_enter/gdk_threads_leave must not be used here?

-------------

PR: https://git.openjdk.java.net/jdk/pull/932

Reply via email to