On Tue, 10 Nov 2020 16:38:25 GMT, Kevin Rushforth <k...@openjdk.org> wrote:

>> Change looks ok from a build point of view, but I can't comment on the 
>> validity and implications of using this key.
>
> I ran a 3D lighting test that is designed to be a GPU stress test. It's a 
> worst case, to be sure, but it take 10 times as long to render with the 
> integrated GPU as it does with the discrete GPU:
> 
> **attenuation.LightingSample: 500 large quads**
> discrete GPU: 23.5 fps
> integrated GPU: 2.34 fps
> 
> In a more realistic example of drawing a large number of 2D vectors, it runs 
> 35% slower with the integrated GPU:
> 
> **Vector charting test, oval clip**
> discrete GPU: 41.1 fps
> integrated GPU: 26.6 fps
> 
> I see similar results in the performance numbers you listed above.
> 
> An application developer who packages up their JDK, for example, using 
> jpackage, can make the decision for themselves. Application developers who 
> rely on the JDK as delivered will get whatever we choose as the default. So 
> we need to be sure that the benefit of doing this justifies the performance 
> hit.

> @kevinrushforth @prrace could you please review?

As we discussed yesterday, it is reviewed but not ready to be approved.
We are waiting for a reply from Apple.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1139

Reply via email to