On Mon, 30 Nov 2020 04:51:32 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:
>> Filed [CSR request](https://bugs.openjdk.java.net/browse/JDK-8255597) > > Please check the tests in the .../test/jdk/java/awt/TrayIcon/ folder it looks > like some of them fail after the fix: > java/awt/TrayIcon/ActionCommand/ActionCommand.java > java/awt/TrayIcon/ActionEventMask/ActionEventMask.java > java/awt/TrayIcon/MouseEventMask/MouseEventMaskTest.java > java/awt/TrayIcon/SecurityCheck/FunctionalityCheck/FunctionalityCheck.java > java/awt/TrayIcon/TrayIconEventModifiers/TrayIconEventModifiersTest.java > java/awt/TrayIcon/TrayIconEvents/TrayIconEventsTest.java > java/awt/TrayIcon/TrayIconMouseTest/TrayIconMouseTest.java > java/awt/TrayIcon/TrayIconPopup/TrayIconPopupTest.java The icon delegate was not listening for mouse events -- thanks for catching this. I've restored the `AWTTrayIconView` thing (so that it can handle mouse events) and made it inherit from `NSStatusBarButton` (so that icon painting is delegated to MacOS). The fix is less verbose now. I've also renamed the property `apple.awt.enableTemplateImages` and added an `@implnote` as discussed in the CSR. Can we consider the CSR approved btw? ------------- PR: https://git.openjdk.java.net/jdk/pull/481
