On Fri, 4 Dec 2020 02:51:19 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:
>> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Moved the new components implementations to the separate files. >> Changed the iitialization procedure to a class function with >> dictionary of role to class name relation. >> >> This pr is still intermittent since it uses the old style >> JNF java call syntacsis. Once fix for JDK-8257853 is integrated >> the calls needs to be converted to the new style but that is a minor >> change. > > src/java.desktop/macosx/native/libawt_lwawt/awt/JavaComponentAccessibility.m > line 1979: > >> 1977: * Implementation of the NSAccessibilityButton protocol >> 1978: */ >> 1979: @implementation ButtonAccessibility > > Do not we need to remove the old `perform()`? Not yet - as i said i'm not going to delete the old code yet si it can be easily reverted for testing and comparison reasons. > src/java.desktop/macosx/native/libawt_lwawt/awt/JavaComponentAccessibility.m > line 1990: > >> 1988: >> 1989: JNIEnv* env = [ThreadUtilities getJNIEnv]; >> 1990: JNFCallStaticVoidMethod(env, jm_doAccessibleAction, [self >> axContextWithEnv:(env)], 0, fComponent); > > Are you sure that the `jm_doAccessibleAction` is always initialized here? Yes. ------------- PR: https://git.openjdk.java.net/jdk/pull/1549