On Wed, 7 Apr 2021 06:39:48 GMT, Andrey Turbanov
<github.com+741251+turban...@openjdk.org> wrote:
>> There are few possible cleanups in java.desktop related to legacy
>> StringBuffer usages:
>> 1. In few places StringBuffer can be replaced with plain String
>> concatenation.
>> 2. StringBuffer can be replaced with StringBuilder. StringBuilder has better
>> performance as it is not thread-safe.
>> 3. There are few places where result of string concatenation is passed to
>> StringBuffer.append method. Using separate `.append` calls is more clear.
>> 4. In few places primitives are unnecessary converted to String before
>> `.append` call. They can be replaced with specialized methods (like
>> `.append(int)` calls.
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> [PATCH] Replace uses of StringBuffer with StringBuilder in java.desktop
>
> fix copyright year
Marked as reviewed by aivanov (Reviewer).
src/java.desktop/unix/classes/sun/awt/X11/XCreateWindowParams.java line 88:
> 86: while (eIter.hasNext()) {
> 87: Map.Entry<Object, Object> entry = eIter.next();
> 88: buf.append(entry.getKey()).append(":
> ").append(entry.getValue()).append("\n");
Would it be clearer if each append was on its own line?
Suggestion:
buf.append(entry.getKey())
.append(": ")
.append(entry.getValue())
.append("\n");
-------------
PR: https://git.openjdk.java.net/jdk/pull/3251
