On Thu, 8 Apr 2021 21:31:29 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:
>> Alexey Ushakov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8258788: incorrect response to change in window insets [lanai] >> >> Moved replaceSurfaceData to more appropriate place > > src/java.desktop/macosx/classes/sun/lwawt/LWWindowPeer.java line 741: > >> 739: if (CGraphicsDevice.usingMetalPipeline() && invalid) { >> 740: replaceSurfaceData(); >> 741: } > > I think fix can be moved to the 729 line "if (pResized || isNewDevice || > invalid)". Looks like it is a bug even in the OGL case, if "pResized == > false" and window is not resized but in the insets were changed we should > update the surface. > > BTW I think the updateMinimumSize() should be called as well since the > minimum/maximum size depends on the insets and NSWindow frame/contentRect. Yes, good idea. Corrected ------------- PR: https://git.openjdk.java.net/jdk/pull/3390