On Fri, 30 Apr 2021 20:50:53 GMT, Alexey Ivanov <[email protected]> wrote:
>> test/jdk/javax/swing/JFileChooser/FileSystemView/SystemIconTest.java line 64:
>>
>>> 62: }
>>> 63:
>>> 64: if (icon.getIconWidth() != size) {
>>
>> Does it make sense to check that the icon is a multi-resolution image with
>> the expected sizes?
>> We know for sure `explorer.exe` contains the entire set of icons.
>
> Since the test always expects a multi-resolution image, does it make sense to
> assert `icon instanceof MultiResolutionImage` at the very least?
Ok, added testing for multiresolution icon.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2875