On Thu, 29 Apr 2021 11:46:25 GMT, Pankaj Bansal <pban...@openjdk.org> wrote:

> Create implementation of native accessibility peer for ScrollPane and 
> ScrollBar Java Accessibility roles.
> 
> There are no direct protocols for these two roles and there is no protocol in 
> list of role based protocols defined by Apple Accessibility API, which can be 
> used for these roles directly. So ScrollAreaAccessibility and 
> ScrollBarAccessibility classes do not implement any of the role based 
> protocols in this list. 
> https://developer.apple.com/library/archive/documentation/Accessibility/Conceptual/AccessibilityMacOSX/ImplementingAccessibilityforCustomControls.html.
>  
> 
> By looking at the current implementation of ScrollAreaAccessibility class in 
> JavaComponentAccessibility and the complete list of properties and methods 
> which can be used for any NSAccessibility class listed in 
> https://developer.apple.com/documentation/appkit/nsaccessibility, custom 
> implementation of ScrollAreaAccessibility and ScrollBarAccessibility is 
> created.
> 
> I have tested these implementations by running ScrollPane demo in SwingSet2 
> and scrollPane demo here 
> https://docs.oracle.com/javase/tutorial/uiswing/components/scrollpane.html. 
> The Voice Over behaviour is consistent with the old implementation and user 
> can navigate and interact with the ScrollArea children hierarchy as expected.
> 
> The old ScrollAreaAccessibility class in JavaComponentAccessibility is 
> renamed to ScrollAreaAccessibility_Old as this was causing compiler errors 
> and we are not deleting old implementations as of now. Please let me know if 
> there is a better way to handle this.
> Also, some constants defined in JavaComponentAccessibility.m have been moved 
> to JavaComponentAccessibility.h to avoid duplication in 
> ScrollAreaAccessibility.

This pull request has now been integrated.

Changeset: 6c107fdf
Author:    Pankaj Bansal <pban...@openjdk.org>
URL:       
https://git.openjdk.java.net/jdk/commit/6c107fdff289cc553df12ee10b0c8002b84059b2
Stats:     367 lines in 7 files changed: 245 ins; 121 del; 1 mod

8264299: Create implementation of native accessibility peer for ScrollPane and 
ScrollBar Java Accessibility roles

Reviewed-by: kizune

-------------

PR: https://git.openjdk.java.net/jdk/pull/3794

Reply via email to