On Thu, 20 May 2021 23:03:02 GMT, Alexander Zuev <kiz...@openjdk.org> wrote:
>> But this is shared code, which has a specification it should work >> everywhere, so even if on Linux and macOS it is not implemented in the best >> way it should return something. > >> But this is shared code, which has a specification it should work >> everywhere, so even if on Linux and macOS it is not implemented in the best >> way it should return something. > > The stuff that is returned by the common code is already tested in UIManager > tests. This issue is windows specific. This implementation at this moment of > time is windows specific. Once we extend implementation - and i mean real > implementation with support for multiple resolution icons - this test will be > updated to reflect it. This is not a specification conformance test, it is > implementation logic test. How it could be tested by the UIManager tests since this is a new method added in this class? I guess it should work just out of the box, no? What is the reason to not enable it, there are some issues? ------------- PR: https://git.openjdk.java.net/jdk/pull/2875
