On Wed, 11 Aug 2021 21:16:43 GMT, lawrence.andrews
<[email protected]> wrote:
>> 1) This testcase was throwing error saying Error: Not a test or directory
>> containing tests: java/awt/print/PrinterJob/XparColor.java
>> 2) Added @test tag so that this testcase can be run
>> 3) Since Applet is deprecated and its not supported any more in the future
>> release remove applet and make the testcase to run as main
>> 4) Since this is a manual testcase instruction frame or dailog was not
>> visible just print dialog was visible so fixed it.
>> 5) When the testcase was run via main method two print dialog was shown one
>> was from main method and one more was from constructor. Fixed to show just
>> one print dialog.
>> 6) Since JDK 17 introduce metal rendering touching the java2d code thought
>> this testcase will be useful to checking the rendering.
>>
>> @shurymury
>
> lawrence.andrews has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Fixed test instruction and execute the testcase on metal only for mac
test/jdk/java/awt/print/PrinterJob/XparColor.java line 134:
> 132: private static void createAndShowTestDialog() {
> 133: String testInstruction = "This testcase will be launched twice
> on mac platform and once on non mac platform.\n" +
> 134: "On Mac once with default pipeline and once again with
> Metal pipeline.\n" +
I think it will be better to rephrase this line with "This test will be run
with default pipeline in all OS and additionally with metal pipeline only in
macOS"
-------------
PR: https://git.openjdk.java.net/jdk/pull/4769
