On Wed, 18 Aug 2021 22:05:18 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixed review comments > > test/jdk/java/awt/im/4959409/bug4959409.java line 162: > >> 160: } >> 161: >> 162: public static void checkSwingTopLevelVisible(javax.swing.JFrame >> jFrame, CountDownLatch topLevelVisibleLatch) throws InterruptedException, >> InvocationTargetException { > > Is there a reason why you use the fully qualified `javax.swing.JFrame` when > it's imported? > > I suggest wrapping `throws` declaration to next line; this line is longer > than 100. > > Both comments apply to the method below. done > test/jdk/java/awt/im/4959409/bug4959409.java line 186: > >> 184: } >> 185: >> 186: public static void checkJComponentVisible(javax.swing.JComponent >> jComponent, CountDownLatch componentVisibleLatch) throws >> InterruptedException, InvocationTargetException { > > You're using fully qualified `javax.swing.JComponent` here: `JComponent` > isn't imported. Why not import it? > > Please also wrap `throws` declaration to the next line. Removed ------------- PR: https://git.openjdk.java.net/jdk/pull/5058