On Sun, 22 Aug 2021 19:46:49 GMT, Phil Race <p...@openjdk.org> wrote:

> There's a long eval in the bug report : 
> https://bugs.openjdk.java.net/browse/JDK-8272806 but here's the summary
> 
> When focus is lost by the app a message is sent down to native setting a 
> native reference to the input method to null
> which is a sort of signal not to notify upwards anything to the input method 
> (which internally will NPE if there's
> no focused component as is the case after focus is lost).
> But we aren't actually setting it to null because of a check for null which 
> previously checked the wrapper for
> the JNI ref was not null but is now obsolete.  So just remove the check for 
> null.
> 
> The steps to reproduce this bug are very manual and involve installing 
> additional input methods and toggling them
> at the system level. So I didn't see a way to write a useful regression test 
> but if you follow the bug report steps you
> should be able to verify the fix.
> 
> I've run all automated tests just for good measure and they all pass.

Marked as reviewed by dmarkov (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/5211

Reply via email to