Hello Pierre,
Thursday, January 25, 2007, 12:49:14 AM, you wrote:
> Hello Paul,
> Paul Sokolovsky a ecrit :
>> Hello Pierre,
>>
>> Tuesday, January 23, 2007, 12:27:48 AM, you wrote:
>>
>>
>>> Finally, I cleaned up the code O:-) ...
>>>
>>
>>
>>> So, here is a new patch that should also work on X50 machines.
>>> You just have to precise your Axim variant ("v" or not) when configuring
>>> the kernel.
>>> The RAM base address should be correctly managed now.
>>> Testers/reviewers are welcome.
>>>
>>
>>
>>> Paul : what do you think about adding this patch to the HH kernel cvs now ?
>>>
>>
>> Sounds good, and by now committed. Thanks for the cleanup you made -
>> it is really visible. Thanks for dropping *_core driver - it is an
>> artifact of hx4700 port, it was done that way to control device
>> initialization order wrt to SoC used there (ASIC3). But since then,
>> another, more clean solution was written ("SoC child devices"), and
>> most ports adopted it. In other words, hx4700's "core" driver is
>> candidate for rewrite.
>>
>> Few other issues:
>>
>> 1. defconfig in the archive was apparently old, selecting aximx30
>> port. I've fixed that, and with current aximx50_defconfig in CVS it
>> builds ok. Can you please check that current vanilla CVS boots ok?
>>
> I can not boot the HEAD cvs HH kernel.
> In fact, I am not so surprized : see my remarks concerning DRAM_BASE below.
>> 2. Nice solution with DRAM_BASE. But does it actually work?
>>
>> include/asm-arm/memory.h:
>> =======
>> ...
>> #include <asm/arch/memory.h>
>> ...
>> #ifndef PHYS_OFFSET
>> #define PHYS_OFFSET (CONFIG_DRAM_BASE)
>> #endif
>> ...
>> =======
>>
>> In our case asm/arch/memory.h will be linked to
>> asm-arm/arch-pxa/memory.h, and it has:
>> =======
>> ...
>> #define PHYS_OFFSET UL(0xa0000000)
>> ...
>> =======
>>
[]
> I am afraid we have to rely on something like this, because PHYS_OFFSET
> is used in head.S to map
> the first MB of memory containing the kernel parameters...
> No right PHYS_OFFSET probably means no atags...
> Why not replace #define PHYS_OFFSET and use systematically DRAM_BASE in
> include/asm-arm/arch-pxa/memory.h ? aka
> #ifndef PHYS_OFFSET
> #define PHYS_OFFSET (CONFIG_DRAM_BASE)
> #endif
> And add consequently something like
> config DRAM_BASE
> hex
> default 0xa8000000 if MACH_X50
> default 0xa0000000
> help
> You should not need to modify this value.
Such proposals should go to mainline kernel. We already
maintain big patchset, so should do everything to minimize patch size,
i.e. of two solutions one which is perfect, and another one is not so
perfect, but still working, and small, we should select second.
In this regard, the simplest solution seems to be to add
#ifdef brackets to asm-arm/arch-pxa/memory.h:
...
#ifndef CONFIG_DRAM_BASE
#define PHYS_OFFSET UL(0xa0000000)
#endif
...
[]
> Pierre
--
Best regards,
Paul mailto:[EMAIL PROTECTED]
--
_______________________________________________
Aximx50-port mailing list
[email protected]
https://www.handhelds.org/mailman/listinfo/aximx50-port