Hello Jean-Nicolas,

Thursday, January 25, 2007, 11:35:31 PM, you wrote:

> Hi Pierre, hi Paul,
> As we should never need to modify DRAM BASE ADDRESS parameter, what
> about just putting the following lines in
> include/asm/arch-pxa/memory.h ?

> /*
>  * Physical DRAM offset.
>  */
> #ifdef CONFIG_MACH_X50
> #define PHYS_OFFSET 0xa8000000
> #else
> #define PHYS_OFFSET 0xa0000000
> #endif

  DRAM_BASE is more generic, so if it exists, that's what should be
used. For example, what if tomorrow we discover handheld with RAM at
0xb0000000 - add another #ifdef? Why, if it can be done solely on
machine Kconfig level, without patching generic headers with
machine-specific details. (Of course, first we need to teach these
generic headers to not override machine's setting).

[]

-- 
Best regards,
 Paul                            mailto:[EMAIL PROTECTED]

-- 
_______________________________________________
Aximx50-port mailing list
[email protected]
https://www.handhelds.org/mailman/listinfo/aximx50-port

Reply via email to