On 6/14/07, Samisa Abeysinghe <[EMAIL PROTECTED]> wrote:
Rajika Kumarasiri wrote: > hello everybody, > I started to work on Mail Transport Sender part first implementing the > following functions which implement the TransportSender interface. > > 1. axis2_status_t AXIS2_CALL > axis2_mail_transport_sender_init( axis2_transport_sender_t > *transport_sender, > > const_axutil_env_t *env > > axis2_conf_ctx_t *conf_ctx, > > axis2_transport_out_desc_t *out_desc); > 2. axis2_status_t AXIS2_CALL > axis2_mail_transport_sender_invoke( axis2_transport_sender_t > *transport_sender, > const > axutil_env_t *env, > > axis2_msg_ctx_t *msg_ctx); > > 3. axis2_status_t AXIS2_CALL > axis2_mail_transport_sender_clean_up( axis2_transport_sender_t > *transport_sender, > > const axutil_env_t *env, > > axis2_msg_ctx_t *msg_ctx); In line with what we already have with HTTP transport, I prefer the prefix 'axis2_smtp_transport_' over 'axis2_mail_transport_', for the function names.
Well, Mail Transport itself is a combination of two protocols (at least) SMTP(sending Emails) and POP3(retrieving Emails). "sender" prefix implies that we use SMTP and in the mail transport receiver part is going to prefix with "receiver" prefix which implies that we use POP3 (or IMAP). One day we will need to extend the EMAIL Transport such that it support other open protocols such as IMAP. At that point there will be conflict in naming(as far as I understand) the function if we are going to prefix sender with "smtp". Your comments are most welcome.
4. void AXIS2_CALL > axis2_http_transport_sender_free( axis2_transport_sender_t > *transport_sender, > const > axutil_env_t *env);
Should this be axis2_smtp_transport_sender_free? Yes , it is. My mistake. Sorry. Regards, Rajika Samisa...
-- Samisa Abeysinghe : http://www.wso2.org/ (WSO2 Oxygen Tank - Web Services Developers' Portal) --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
-- http://rajikacc.blogspot.com/
