I think this is an "over design" problem. And also, may be this is inherited form Java implementation.

I too think we can use a sting here, and not a hash. Anyway, it would be good to test this after the change for regression.

Samisa...

Nandika Jayawardana wrote:
I found the following peice of code in http sender on line number 733.

content_type_property = (axutil_property_t *)
axis2_msg_ctx_get_property (msg_ctx, env,
AXIS2_USER_DEFINED_HTTP_HEADER_CONTENT_TYPE);

            if (content_type_property)
            {
                content_type_hash = (axutil_hash_t *)
                    axutil_property_get_value (content_type_property, env);
                if (content_type_hash)
                {
                    content_type_value =
                        (char *) axutil_hash_get (content_type_hash,

AXIS2_HTTP_HEADER_CONTENT_TYPE,
                                                  AXIS2_HASH_KEY_STRING);
                }

                content_type_value = 
axutil_property_get_value(content_type_property, env);
            }

            if (content_type_value)
            {
                content_type = content_type_value;
            }
            else
            {
                content_type = AXIS2_HTTP_HEADER_ACCEPT_TEXT_XML;
            }

I think this property (AXIS2_USER_DEFINED_HTTP_HEADER_CONTENT_TYPE)
should be used to set the content type from a service. Is there any
reason for value of this property  to be a hash table instead of a
string ?

Regards
Nandika

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
------------------------------------------------------------------------


No virus found in this incoming message.
Checked by AVG. Version: 8.0.100 / Virus Database: 269.23.21/1457 - Release Date: 5/20/2008 4:45 PM


--
Samisa Abeysinghe Director, Engineering; WSO2 Inc.

http://www.wso2.com/ - "The Open Source SOA Company"


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to