Manjula Peiris wrote:
On Mon, 2008-06-16 at 18:05 +0530, Samisa Abeysinghe wrote:
Manjula Peiris wrote:
Hi devs,

I see in util/axutil_utils_defines.h two types in the $subject are
tydefed to char. axis2_char may be useful when we support unicode. But
Is there any reason for defining this axis2_byte.

And if we need to cast axis2_char_t * to char* isn't it enough to just
do a pointer casting. Because in mime_output.c I see a method called
axis2_char_2_byte which mallocs a new buffer of axis2_byte and cast each
axis2_char character to axis2_byte and copying. I think it is a waste.
What is the line number.

axiom/src/attachments/mime_output.c:608

Yes it is a waste. I am not sure why this was done in the first place. There is no code comment either explaining what is going on.

So change and test.

Samisa...

Samisa...

Any thoughts ?

Thanks,
-Manjula. ------------------------------------------------------------------------


No virus found in this incoming message.
Checked by AVG. Version: 8.0.100 / Virus Database: 270.3.0/1505 - Release Date: 6/16/2008 7:20 AM


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
------------------------------------------------------------------------


No virus found in this incoming message.
Checked by AVG. Version: 8.0.100 / Virus Database: 270.3.0/1505 - Release Date: 6/16/2008 7:20 AM


--
Samisa Abeysinghe Director, Engineering; WSO2 Inc.

http://www.wso2.com/ - "The Open Source SOA Company"


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to