Glen, James,

FYI. I backed out the underscore changes as well. I ran "ant clean all-tests" and that 
ran fine.

Thanks,
dims

--- Glen Daniels <[EMAIL PROTECTED]> wrote:
> 
> Yeah, I commented that out as I've been working on soap 1.2 stuff too.  James,
> this is not the right fix for this problem.  I haven't fully analyzed the
> situation, but it's certainly not good to simply ignore matches like this.  It
> broke several things in both the unit tests and my tests.
> 
> I can try to take a look at this if I get a breather later today, but right now
> I'm trying to get my 1.2 changes ready to commit (i.e. running all-tests) and
> on a slow machine, that's a bitch.  Side note - there has to be something we
> can do about how slow the build is these days....
> 
> --G
> 
> ----- Original Message -----
> From: <[EMAIL PROTECTED]>
> To: <[EMAIL PROTECTED]>
> Sent: Friday, February 28, 2003 9:59 AM
> Subject: cvs commit: xml-axis/java/src/org/apache/axis/message RPCElement.java
> 
> 
> > dims        2003/02/28 06:59:37
> >
> >   Modified:    java/src/org/apache/axis/message RPCElement.java
> >   Log:
> >   Breaks "ant clean all-tests"....Commenting it out till James gets a chance
> to take a look.
> >
> >   Revision  Changes    Path
> >   1.83      +10 -10
> xml-axis/java/src/org/apache/axis/message/RPCElement.java
> >
> >   Index: RPCElement.java
> >   ===================================================================
> >   RCS file:
> /home/cvs/xml-axis/java/src/org/apache/axis/message/RPCElement.java,v
> >   retrieving revision 1.82
> >   retrieving revision 1.83
> >   diff -u -r1.82 -r1.83
> >   --- RPCElement.java 27 Feb 2003 21:12:10 -0000 1.82
> >   +++ RPCElement.java 28 Feb 2003 14:59:37 -0000 1.83
> >   @@ -251,16 +251,16 @@
> >                                    if(!JavaUtils.isConvertable(value,
> sigType))
> >                                        match = false;
> >
> >   -                                if (!sigType.isArray() &&
> value.getClass().isArray() &&
> >   -                                    !sigType.equals(Object.class)) {
> >   -                                      match = false;
> >   -                                }
> >   -
> >   -                                if (operation.getUse() == Use.ENCODED &&
> >   -                                    sigType.isArray() &&
> >   -                                    !value.getClass().isArray()) {
> >   -                                      match = false;
> >   -                                }
> >   +                                //if (!sigType.isArray() &&
> value.getClass().isArray() &&
> >   +                                //    !sigType.equals(Object.class)) {
> >   +                                //      match = false;
> >   +                                //}
> >   +                                //
> >   +                                //if (operation.getUse() == Use.ENCODED &&
> >   +                                //    sigType.isArray() &&
> >   +                                //    !value.getClass().isArray()) {
> >   +                                //      match = false;
> >   +                                //}
> >                                }
> >                            }
> >                            // This is not the right operation, try the next
> one.
> >
> >
> >
> >
> 


=====
Davanum Srinivas - http://webservices.apache.org/~dims/

__________________________________________________
Do you Yahoo!?
Yahoo! Tax Center - forms, calculators, tips, more
http://taxes.yahoo.com/

Reply via email to