Hi Eran!
I predicted this reply :-)
Then, at least the names should be changed. Otherwise
readability&usability of code is at stake.
We can have
public Iterator getAttributesNS(OMNamespace ns) to do what you wanted to do. 

And when syntactically only one attribute with a given qname
(namespace + localname) can exist in an element, calling a
getFirstAttribute(qname) wouldn't look nice. Can its signature be
changed to
public OMAttribute getAttribute(QName qname)

If the suggested changes sound agreeable can you do them at your
earliest convenience.

Thank you
Jayachandra

On 5/18/05, Eran Chinthaka <[EMAIL PROTECTED]> wrote:
> Nope.
> 
> public OMAttribute getFirstAttribute(QName qname) throws OMException will
> fullfil that thing.
> 
> But the  public Iterator getAttributes(QName qname) method will do something
> different.
> 
> Well from this method what I expected was, one can just get give the
> namespace and get all the attributes with that same namespace, like that.
> Well, I think I implemented this, but its now not in the source.
> 
> Let me look at this.
> 
> Regards,
> Chinthaka
> 
> > -----Original Message-----
> > From: Glen Daniels [mailto:[EMAIL PROTECTED]
> > Sent: Wednesday, May 18, 2005 1:32 AM
> > To: [email protected]; 'jayachandra'
> > Subject: RE: [Axis2] OMElement API notes
> >
> >
> > You are quite right, Jaya.  That should get fixed.
> >
> > --Glen
> >
> > > -----Original Message-----
> > > From: jayachandra [mailto:[EMAIL PROTECTED]
> > > Sent: Tuesday, May 17, 2005 6:58 AM
> > > To: [email protected]
> > > Subject: [Axis2] OMElement API notes
> > >
> > > Resending with [Axis2] prefix
> > >
> > > ---------- Forwarded message ----------
> > > From: jayachandra <[EMAIL PROTECTED]>
> > > Date: May 17, 2005 4:27 PM
> > > Subject: OMElement API notes
> > > To: [email protected]
> > >
> > >
> > > Hi!
> > > I see the following method signature in OMElement.java
> > >   public Iterator getAttributes(QName qname);
> > >
> > > Should it not be something like
> > >   public OMAttribute getAttribute(QName qname);
> > >
> > > Can there be a list of (more than one) attributes with the same qname
> > > in an element? Am I mistaken somewhere?
> > >
> > > Thank you
> > > Jaya
> > > --
> > > -- Jaya
> > >
> > >
> > > --
> > > -- Jaya
> > >
> > >
> 
> 


-- 
-- Jaya

Reply via email to