[ 
http://issues.apache.org/jira/browse/AXIS-2068?page=comments#action_12314316 ] 

Venkat Reddy commented on AXIS-2068:
------------------------------------

hmm .. i'm not sure if this is necessary. detachNode calls removeChild, so the 
dirty flag is set inside the removeChild. Also, this patch sets the dirty flag 
even if parent is null.

For set parent, the dirty flag is set inside the appendChild(), marking the 
parent as dirty. Child is not set as dirty, becuase its content won't change 
much during serialiazation, because of the change in parent, but it will for 
the parent.

- venkat

> Missing setDirty flags in SAAJ tree modification (detachNode and setParent)
> ---------------------------------------------------------------------------
>
>          Key: AXIS-2068
>          URL: http://issues.apache.org/jira/browse/AXIS-2068
>      Project: Apache Axis
>         Type: Bug
>   Components: SAAJ
>     Versions: 1.2.1
>     Reporter: David Blevins
>  Attachments: setdirty.patch
>
> This patch takes care of a couple areas where the MessageElement (NodeImpl) 
> isn't getting marked as dirty when things are detached or the parent is 
> changed.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to