[ http://issues.apache.org/jira/browse/AXIS2-81?page=comments#action_12316098 ]
Eran Chinthaka commented on AXIS2-81: ------------------------------------- Thanks for the if statement comment. I fixed it. I'm not that clear about your comment on fault code. Can u please elaborate that a bit, please ? Currently what I do is, I get the value from the subcode and print it as the text of faultcode, for SOAP 1.1. And the reference you have given is not giving me enough information :(. Chinthaka > SOAP11FaultSubCodeImpl.checkParent(OMElement) has wrong if condition > -------------------------------------------------------------------- > > Key: AXIS2-81 > URL: http://issues.apache.org/jira/browse/AXIS2-81 > Project: Apache Axis 2.0 (Axis2) > Type: Bug > Components: core > Versions: 0.9 > Environment: all > Reporter: Gopalakrishnan > > The current code has a set of parenthesis missing, which makes a valid > condition fail. > if (!(parent instanceof SOAP11FaultSubCodeImpl) || (parent instanceof > SOAP11FaultCodeImpl)) > should have been > if (! ( (parent instanceof SOAP11FaultSubCodeImpl) || (parent instanceof > SOAP11FaultCodeImpl) ) ) . > Another enhancement suggestion is when the code has a subcode added, > serialize() can serialize it as > codeValue.subcodeValue. This is how subcodes have to be represented in > SOAP1.1, since it doesn't define a <subcode> child element for <code> (check > : http://www.w3.org/TR/2000/NOTE-SOAP-20000508/#_Toc478383510) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira