[ http://issues.apache.org/jira/browse/AXIS-2139?page=comments#action_12317766 ]
Venkat Reddy commented on AXIS-2139: ------------------------------------ Dims, I'm not sure what's meant by "MessageElement DOM is incomplete". The deserializatin and serialization wasn't breaking XML comparison, even before my patch, as shown the test case that I have attached (Test2139). Here is more explanation on my fix: When an element is NOT dirty, MessageElement.output() replays the recorder, and the serialized form of the ME is identical to what it was when deserialized. If the element is dirty, then the output method does the serialization, resulting in a form that may not be identical to its original form. My patch would ensure that recorder is replayed during serialization in case the message is never modified since deserialization, which is desirable. The test case I attached shows that the message is preserved canonically. Please let me know if we need to do something else to prevent digital signature break. Steve, do you have a test case that demonstrates your digital signature break? - Venkat > SAX recorder is dirty after deserialization > ------------------------------------------- > > Key: AXIS-2139 > URL: http://issues.apache.org/jira/browse/AXIS-2139 > Project: Apache Axis > Type: Bug > Components: Serialization/Deserialization > Versions: current (nightly) > Reporter: Steve Green > Assignee: Venkat Reddy > Priority: Blocker > Attachments: Test2139.java, test.java > > During parsing of a message, SAX events are stored in the recorder, and > MessageElement objects are created. The insertion of the new MessageElements > are setting _isDirty, and thus invalidating the recorder for serialization. > In my particular case, this breaks digital signatures becuase the > MessageElement DOM is incomplete (it's missing some whitespace text nodes). > It seems to me that it doesn't make sense to dirty the recorder during > recording itself. This problem seemed to be created at version 1.13 of > NodeImpl. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
