Folks, I've moved the dom stuff out of the way and made the saaj build optional. Now looking at test failures in JDK1.5
thanks, -- dims On 10/28/05, Eran Chinthaka <[EMAIL PROTECTED]> wrote: > Hi all, Ruchith ;-) , > > > Ruchith Fernando wrote: > Hi All, > > The DOM impl that we have in the xml module implements the OM > interfaces. Therefore I included it under > org.apache.axis2.om.impl.dom.* > And I expected this to be used the same way we would use the llom > implementation of OM. (The linked list implementation of OM goes under > org.apache.axis2.om.impl.llom.*). > > But if you guys feel that the DOM stuff doesn't belong in the XML > module please feel free to (re?)move it :-). > remove it ? No way. Lets move it. We really need that. > > But I'd still like to > have a clean impl which implements DOM and OM interfaces. > > +1. > > > Thanks > Ruchith > > On 10/28/05, Eran Chinthaka <[EMAIL PROTECTED]> wrote: > > > Steve Loughran wrote: > > > > Davanum Srinivas wrote: > > > > Should we break out the DOM2/DOM3 stuff from xml module? just like we > did for saaj? > > > well, the issue is that both the OMElement and the SAAJ stuff declare > that they implement the dom interfaces, and you cannot build them on > java1.5 without marking every impl class as abstract. So I dont think > 'breaking out' is something > we can do. > > This is COMPLETELY wrong idea. OM has nothing to do with dom impl. > > Actually I wanted to point this out earlier, but since Ruchith is doing > some important stuff, I kept quiet. I don't think dom impl stuff belongs > to OM. Its an extension of OM. This has made people to comment wrong on > OM, which Steve just did. > > As Dims stated, its better if we can strip this out from OM. > > -- Chinthaka > > > > > > > -- > Ruchith > > > > -- Davanum Srinivas : http://wso2.com/blogs/
