[ 
http://issues.apache.org/jira/browse/AXIS2-359?page=comments#action_12361868 ] 

Sanjiva Weerawarana commented on AXIS2-359:
-------------------------------------------

Um, is the fix to this just the stuff that was in the original issue report? If 
so that hardly qualifies as  "deep mess". 

Come on Dims, we *do* leverage Axis1 .. I can't believe you are saying that we 
should get much/anything out of the old symboltable mess that Axis1's WSDL2Java 
was/is. Just because there are certain cases we don't handle doesn't mean we 
are not learning from the past. That's exactly why we're still in 0.93+ and not 
in 1.xx.

BTW http://soapinterop.java.sun.com/round3/groupd/imported/import2B.wsdl does 
not appear to be WS-BP 1.0 compliant; did they not outlaw importing XSDs using 
wsdl:import?

> Stack overflow when processing XSD with mutual recursion
> --------------------------------------------------------
>
>          Key: AXIS2-359
>          URL: http://issues.apache.org/jira/browse/AXIS2-359
>      Project: Apache Axis 2.0 (Axis2)
>         Type: Bug
>   Components: wsdl
>     Versions: 0.9, 0.91, 0.92, 0.93
>  Environment: Win2K, Java  1.4.2_08-b03, Axis2 0.91, Axis2 0.93
>     Reporter: Kevin J. Winters

>
> The recursive method WSDLPump.pushSchemaElement(...) does not protect against 
> schemas with mutual recursion.  A check of already processed namespaces could 
> be used to prevent the stack overflow in a manner similar to:
>    ...
> /** begin mod **/
>     private HashSet schemaCache = new HashSet();
> /**  end mod  **/
>    
>     private void pushSchemaElement(Schema originalSchema,Stack stack){
>         if (originalSchema==null){
>             return;
>         }
>    
> /** begin mod **/
>         if ( schemaCache.contains(originalSchema.getDocumentBaseURI())) {
>             return;
>         } else {
>             schemaCache.add(originalSchema.getDocumentBaseURI());
>         }
> /**  end mod  **/
>         stack.push(originalSchema);
>         ...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to