[ADB] Feedback from Wendy's POC
-------------------------------
Key: AXIS2-736
URL: http://issues.apache.org/jira/browse/AXIS2-736
Project: Apache Axis 2.0 (Axis2)
Type: Bug
Reporter: Davanum Srinivas
See original email here:
http://mail-archives.apache.org/mod_mbox/ws-axis-dev/200605.mbox/[EMAIL
PROTECTED]
4. Bug: GetAppReleasesType.java does not compile.
In the GetAppReleasesType#Factory.parse method, a reference is made to the
nonexistent method "
org.apache.axis2.databinding.utils.ConverterUtil.convertToNonNegativeInteger(content)
".
The correct method name is "
org.apache.axis2.databinding.utils.ConverterUtil.convertTononNegativeInteger(content)
". Note: There is a correct reference to the
org.apache.axis2.databinding.utils.ConverterUtil.convertTononNegativeInteger
method in the AppRelease#Factory.parse method. This leads me to conclude
that you are not using common methods to determine which conversions to
perform on input vs. output content, and so bugs that are caught in one
class may still be unidentified in another class.
5. Bug: In AppRelease.java, the values for localAvailabilityStopTracker
and localReleaseDescTracker are not set properly.
In the setters for the attributes that these Trackers track, the following
code should be used to ensure that the Trackers are set properly:
For localAvailabilityStopTracker -
public void setAvailabilityStop(java.util.Date param) {
// update the setting tracker
localAvailabilityStopTracker = (param != null);
this.localAvailabilityStop = param;
}
For localReleaseDescTracker -
public void setReleaseDesc(java.lang.String param) {
// update the setting tracker
localReleaseDescTracker = true;
this.localReleaseDesc = param;
}
As generated by WSDL2Java, the Tracker is set to true even if the variable
it is tracking is unset back to null.
6. Bug: In the AppReleaseResponse.setReturn method, the value of
local_returnTracker may be set to true, but it will never be unset.
Similar to Bug #3, the local_returnTracker should be set using the
following code to ensure that it is unset when the supplied parm is null:
public void set_return(com.wendys.ws.apprelease.AppRelease[] param) {
validate_return(param);
// update the setting tracker
local_returnTracker = (param != null);
local_return = param;
}
7. Annoyance: In the AppReleaseResponse.addReturn method,
local_returnTracker only needs to be set to true when the local_return
array is instantiated, not every time an AppRelease is added to the array.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
