Sure, what package did you have in mind? I could not make one up so i stuck it in engine.
-- dims On 8/17/06, David Illsley <[EMAIL PROTECTED]> wrote:
Hi Dims, I'm not sure that I agree with the logic. Handler and MessageReceiver are both spi level artifacts whereas Service is an api level one that I'd expect end users to use. I'm not even sure that spi level users should be exposed to the implementation detail that is the engine package but I'm sure that I don't think that api level users should. If org.apache.axis2.Service isn't appropriate could we have an alternative which doesn't require looking at the engine package? Cheers, David On 15/08/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > Author: dims > Date: Tue Aug 15 05:55:03 2006 > New Revision: 431594 > > URL: http://svn.apache.org/viewvc?rev=431594&view=rev > Log: > Handler, MessageReceiver interfaces are in the engine package, so moving the new Service interface there as well. > > > Added: > webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/engine/Service.java > - copied, changed from r431586, webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/Service.java > Removed: > webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/Service.java > Modified: > webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/engine/DependencyManager.java > > Modified: webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/engine/DependencyManager.java > URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/engine/DependencyManager.java?rev=431594&r1=431593&r2=431594&view=diff > ============================================================================== > --- webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/engine/DependencyManager.java (original) > +++ webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/engine/DependencyManager.java Tue Aug 15 05:55:03 2006 > @@ -18,7 +18,6 @@ > package org.apache.axis2.engine; > > import org.apache.axis2.AxisFault; > -import org.apache.axis2.Service; > import org.apache.axis2.context.OperationContext; > import org.apache.axis2.context.ServiceContext; > import org.apache.axis2.context.ServiceGroupContext; > @@ -49,7 +48,7 @@ > // if this service is implementing the o.a.a.Service interface, then use that fact to invoke the > // proper method. > if (obj instanceof Service) { > - ((Service) obj).setOperationContext(opCtx); > + ((org.apache.axis2.engine.Service) obj).setOperationContext(opCtx); > } else { > Class classToLoad = obj.getClass(); > > @@ -81,8 +80,8 @@ > public static void initServiceClass(Object obj, > ServiceContext serviceContext) throws AxisFault { > try { > - if (obj instanceof Service) { > - Service service = (Service) obj; > + if (obj instanceof org.apache.axis2.engine.Service) { > + Service service = (org.apache.axis2.engine.Service) obj; > service.init(serviceContext); > } else { > Class classToLoad = obj.getClass(); > @@ -150,7 +149,7 @@ > if (obj != null) { > Class classToLoad = obj.getClass(); > if (obj instanceof Service) { > - Service service = (Service) obj; > + org.apache.axis2.engine.Service service = (Service) obj; > service.destroy(serviceContext); > } else { > // We can not call classToLoad.getDeclaredMethed() , since there > > Copied: webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/engine/Service.java (from r431586, webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/Service.java) > URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/engine/Service.java?p2=webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/engine/Service.java&p1=webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/Service.java&r1=431586&r2=431594&rev=431594&view=diff > ============================================================================== > --- webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/Service.java (original) > +++ webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/engine/Service.java Tue Aug 15 05:55:03 2006 > @@ -15,7 +15,7 @@ > */ > > > -package org.apache.axis2; > +package org.apache.axis2.engine; > > import org.apache.axis2.context.OperationContext; > import org.apache.axis2.context.ServiceContext; > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > -- David Illsley - IBM Web Services Development
-- Davanum Srinivas : http://www.wso2.net (Oxygen for Web Service Developers) --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
