[
http://issues.apache.org/jira/browse/AXIS2-1085?page=comments#action_12444047 ]
Rich Scheuerle commented on AXIS2-1085:
---------------------------------------
I loaded the patch onto my machine. Here are my questions:
1) It appears that the Axis2 has not been changed to use the Filter ? Is this
correct ? Please let me know when you have the final patch.
2) The FilterDemo and FilterConfigDemo worked. Can you convert these into
testcases and add some additional asserts?
3) The contributed code is high quality, but lacks javadoc. Can you please
provide class and method javadoc for the contributed code (especially Filter
and FilterRegistry) ?
4) Filter has a single method the references the context:
public XMLStreamReader init(XMLStreamReader reader, Object context);
FilterRegistry has two references to the context:
public XMLStreamReader enableFilter(XMLStreamReader reader, Object
context)
public XMLStreamReader insertFilter(XMLStreamReader reader, Object
context)
Should the context be an Object or should the context be
org.apache.axis2.context.MessageContext ?
> StAX Filter [ Data conversion, extraction, or do something between
> XMLStreamReader and StAXBuilder]
> ---------------------------------------------------------------------------------------------------
>
> Key: AXIS2-1085
> URL: http://issues.apache.org/jira/browse/AXIS2-1085
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: New Feature
> Components: core
> Environment: windows
> Reporter: Takahide Nogayama
> Assigned To: Rich Scheuerle
> Attachments: patchAXIOM_to_moduleaxiom-apisrcmainjava.txt,
> patchAXIS2_to_moduleskernelsrc.txt, src_demo.zip,
> StAX_filter_architecture.ppt,
> ver2_patch_to_axiom_modules_axiom-api_src_main_java_org_apache_axiom_om_impl_builder.txt,
> ver2_patch_to_axis2_modules_kernel_src_org_apache_axis2_transport.txt,
> ver5_patch_to_axis2_modules.txt
>
>
> To use this Filter in AXIS2, we have to change AXIS2 alittle.
> See
> http://issues.apache.org/jira/browse/WSCOMMONS-76
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
