Sounds good to me! +1

On 2/9/07, Dennis Sosnoski <[EMAIL PROTECTED]> wrote:
Paul Fremantle wrote:
> Dennis
>> Only if the user actually implements the ping-handling code themselves,
>> and checks the various conditions that can go wrong in the operation of
>> the service code. Was that the intention, that this be exposed to the
>> user to implement? I don't know see offhand how this would work, given
>> that somewhere around 95% of Axis2 services are using generated code.
>> Just having it go to a MessageReceiver default implementation seems to
>> add zero value beyond what you get by querying the admin service.
>
> There is a simple value that can be had from going to the MR - the MR
> can try to instantiate the Java object. This at least tests a few of
> the major classpath issues that you might get from a service deployer.
>
> Ideally we could also generate a ping() method on skeletons that would
> encourage users to write a more thorough test. We could use reflection
> to invoke it if it exists.

I really dislike using reflection for this type of thing, since it means
that "magic" methods change the behavior of things at runtime. It'd be
easy enough to do this as an interface, though. So the message receiver
could check if the service class implements the pingable interface, and
if so it calls the method defined by that interface. Otherwise, it just
checks that it can create an instance of the service class.

That seems like a reasonable approach - no impact on users who just use
the default behavior, but easy for anyone who wants to support the added
value to do so. Does anyone object to implementing it this way?

  - Dennis

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




--
Davanum Srinivas :: http://wso2.org/ :: Oxygen for Web Services Developers

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to