Hi Chinthaka!
1) Messages should be internationalized and accessed via resource APIs.
Really. At some point we should all stop working on features and take
a few days to hang out and make a serious push to do this across the
board. After that's done we should implement a daily automated scan
(like Axis1 does on each build) across the source to alert us of
non-internationalized messages.
Glen, thanks for owning the process of I18N'ing everything. This was in
our todo list for a long time but no one had a chance to do it. I hope
you are the best person for that ;)
LOL :) Seriously, though, someone probably does need to own the
structural part (making sure that we have common utilities for getting
messages and finding resource files). The actual work of moving the
messages into resource files and changing the code should be a task that
we split up and everyone shares... ApacheCon EU's hackathon might be a
good time for this kind of thing....
2) When generating exceptions like this, it really isn't very useful to
say "received some other implementation" or "value wasn't what was
expected". It's much more helpful to actually put the problem value
into the exception.... In this case it only takes an extra moment to code
"but received " + reason.getClass() + "."
1000 appologies for this code written by me some time back. Won't happen
again :(.
Don't take it personally (I was hoping for a ":)" instead of a ":("), we
really do have these kinds of issues everywhere and we ALL do this stuff
sometimes. I just happened to notice this a bunch of places and think
it's useful to remind ourselves of patterns.
--Glen
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
