[
https://issues.apache.org/jira/browse/AXIS2-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jaliya Ekanayake resolved AXIS2-2642.
-------------------------------------
Resolution: Fixed
The getEngagedModules() in AxisServiceGroup and AxisService are both renamed to
getEngagedModulesNames() to resolve the ambiguity.
AxisServiceGroup's getEngagedModulesNames() is now returning a Collection
instead of ArrayList.
We don't need to keep copies of engaged modules in all these places as it is
available in AxisConfig.
> Inconsistencies in getting engaged modules
> -------------------------------------------
>
> Key: AXIS2-2642
> URL: https://issues.apache.org/jira/browse/AXIS2-2642
> Project: Axis 2.0 (Axis2)
> Issue Type: Bug
> Environment: Any
> Reporter: Saminda Wishwajith Abeyruwan
> Assignee: Jaliya Ekanayake
> Priority: Blocker
>
> We've came across the following inconsistencies when calling
> getEngagedModules() method, in
> 1. AxisOperation
> 2. AxisService
> 3. AxisServiceGroup
> AxisOperation has,
> public Collection getEngagedModules() {...} --> This will give an instance of
> ArrayList which has AxisModule objects.
> AxisService has,
> public Collection getEngagedModules() {...} --> This will give an instance of
> ArrayList which has String objects.
>
> String objects are the names of engaged modules.
> AxisServiceGroup has,
> public ArrayList getEngagedModules() {...} --> This will give an instance of
> ArrayList which has String objects.
>
> String objects are the names of engaged modules.
> This will lead to difficulties when working with them.
> IMHO getEngagedModules() should be an abstract method in AxisDescription;
> public List getEngagedModules(),
> and should return either AxisModule or Name of the module as String. IMHO
> AxisModule would be preferable. Thus, others that extend from AxisDecription
> will be benefited too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
