The proposed solution definitely looks cleaner than the current
implementation. The only concern is that we will have to preserve backward
compatibility, hence the old way of configuring the proxy should also
continue to work.
-- Azeez
On 6/14/07, Saminda Abeyruwan <[EMAIL PROTECTED]> wrote:
Devs,
When considering the JIRAS 2316 & 2214 regarding client side proxy
configuration, IMHO how we configure the proxy through Axis2.xml is highly
inefficient and ugly .
(Proxy can also be configured using runtime with
HttpTransportProperties.ProxyProperties, IMO it is doing exactly what we
need).
My concern is when we configure proxy through Axis2.xml in client side. At
the moment to configure the proxy we need to do the following
<transportSender name="*http*"
class="org.apache.axis2.transport.http.CommonsHTTPTransportSender">
<parameter name="PROTOCOL" locked="false">HTTP/1.1</parameter>
<parameter name="PROXY" proxy_host="proxy_host_name" proxy_port="proxy_host_port"
locked="true>userName:domain:passWord</parameter>
</transportSender>
The above is very inefficient and it's hard to even follow.
The other problem I see with this approch is that proxy is configured
under transport "http". What if the user only has "https" and need to use
proxy.
Thus I propose to get rid of the parameter named "PROXY" completely and
introduce an independent toplevel parameter to Axis2.xml named "Proxy"
following the convention.
Thus,
it would be like,
<parameter name="Proxy">
<Configuration>
<ProxyHost>example.org</ProxyHost>
<ProxyPort>5678</ProxyPort>
<ProxyUser>saminda\example</ProxyUser> // user\domain
<ProxyPassword>ppp</ProxyPassword>
</Configuration>
</parameter>
At this way the senders may be http or https proxy configuration will
apply to both.
I will update the Docs as proposed.
What would be your consensus on prior ?
Thank you
Saminda
--
Saminda Abeyruwan
Software Engineer
WSO2 Inc. - www.wso2.org
--
Thanks
Afkham Azeez
http://www.wso2.org
GPG Fingerprint: 643F C2AF EB78 F886 40C9 B2A2 4AE2 C887 665E 0760
