[
https://issues.apache.org/jira/browse/AXIS2-4477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andreas Veithen updated AXIS2-4477:
-----------------------------------
Attachment: AXIS2-4477.patch.txt
Amila,
I think we should eliminate the root cause of this problem once and for all by
letting the code generator keep track of all files it generates (not just the
XML files). This will solve the problem regardless of the flattenFiles option
and will also work if the user has added other files to the source directory.
Attached a patch that implements this approach.
WDYT?
> wsdl2java should only prettify files it has generated itself
> ------------------------------------------------------------
>
> Key: AXIS2-4477
> URL: https://issues.apache.org/jira/browse/AXIS2-4477
> Project: Axis 2.0 (Axis2)
> Issue Type: Bug
> Components: codegen
> Affects Versions: 1.5.1, 1.5, 1.4.1
> Reporter: Andreas Veithen
> Priority: Minor
> Attachments: AXIS2-4477.patch.txt, codegen.patch
>
>
> In AXIS2-2947 it was requested to make the prettify feature in wsdl2java more
> selective, but this has only been done for XML files. The problem still
> persists for Java files: if the output directory contains Java files that
> have not been generated by wsdl2java, then these files will be reformatted
> too. The prettify feature should be strictly limited to files that have been
> generated by wsdl2java.
> Additional notes:
> - The fact that JavaPrettyPrinterExtension scans the entire output directory
> is the actual root cause of AXIS2-4107.
> - The change in AXIS2-2947 has a severe design flaw because it changed
> AbstractPrettyPrinterExtension to limit itself to generated XML files. It
> should limit itself to files of any type generated by wsdl2java and give
> subclasses the opportunity to filter these files by type.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
