That is not correct. The entire Javadoc of the cleanupTransport method was written before the introduction of the AUTO_OPERATION_CLEANUP property. It only refers to "callTransportCleanup", which is a different property. Since the AUTO_OPERATION_CLEANUP feature is something that has been recently introduced by Glen for the 1.5.1 release, it would be good to start a discussion to get his feedback if you think that the default value should be different for the next release.
Andreas On Wed, Nov 11, 2009 at 23:54, <wood...@apache.org> wrote: > Author: woodroy > Date: Wed Nov 11 22:54:35 2009 > New Revision: 835113 > > URL: http://svn.apache.org/viewvc?rev=835113&view=rev > Log: > Use proper default value of AUTO_OPERATION_CLEANUP property > > Javadoc for cleanupTransport states the default value is 'false' > > Modified: > > webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/ServiceClient.java > > Modified: > webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/ServiceClient.java > URL: > http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/ServiceClient.java?rev=835113&r1=835112&r2=835113&view=diff > ============================================================================== > --- > webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/ServiceClient.java > (original) > +++ > webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/client/ServiceClient.java > Wed Nov 11 22:54:35 2009 > @@ -660,7 +660,7 @@ > public OperationClient createClient(QName operationQName) throws > AxisFault { > // If we're configured to do so, clean up the last OperationContext > (thus > // releasing its resources) each time we create a new one. > - if > (JavaUtils.isTrue(getOptions().getProperty(AUTO_OPERATION_CLEANUP), true) && > + if > (JavaUtils.isTrue(getOptions().getProperty(AUTO_OPERATION_CLEANUP), false) && > !getOptions().isUseSeparateListener()) { > cleanupTransport(); > } > > >
