DeploymentFileData missing NULL check -- NullPointerException guaranteed from
DeploymentEngine.buildServiceGroup
----------------------------------------------------------------------------------------------------------------
Key: AXIS2-4619
URL: https://issues.apache.org/jira/browse/AXIS2-4619
Project: Axis2
Issue Type: Bug
Affects Versions: 1.5.1
Environment: * Java:
java version "1.6.0_16"
Java(TM) SE Runtime Environment (build 1.6.0_16-b01)
Java HotSpot(TM) Client VM (build 14.2-b01, mixed mode, sharing)
* Eclipse Dynamic Web Project
* Apache Axis2 v1.5.1
Reporter: Dave Lindquist
The class DeploymentFileData has the following interesting lines of code:
public class DeploymentFileData {
...
public DeploymentFileData(File file) {
this.file = file;
}
...
public String getName() {
return file.getName(); // No need to check for null due to
constructor check
}
Note the comment, and the lack of any check in the constructor!
Moreover, in DeploymentEngine, in the buildServiceGroup method, the VERY FIRST
LINE (1103) says:
DeploymentFileData currentDeploymentFile = new DeploymentFileData(null,
null);
in other words, guaranteed NullPointerException if you call this method!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
