Thanks Ajith! Unfortunately, I need to send you a revised version.
There is a stupid mistake in my xsl that broke the other types! I had
only verified that the <choice> code worked, not yet verified
that the rest of the generated code wasn't affected. It's a trivial
change I'm testing now, so should be just few. Mea culpa -- sorry for
the confusion.
Regarding the code, it is very easy to read. I compliment you on the
organizaiton.
Chuck
Hi Chuck,
I looked at your solution and it is reasonable for handling choice. I
applied the patch (Actually modified the classes looking at the patch.
TortoiseSVN throws an exception when I try to apply the given patch)
Thanks a lot for your effort in participating in the development
effort. We really appreciate you coming forward and solving this issue.
I've already solved the ref issue.
BTW you seem to have understood the workings of the code well. Did it
take a lot of effort to figure out the stuff ?
On 1/25/06, Chuck Williams <[EMAIL PROTECTED]> wrote:
Dims and Ajith,
I took Dims' advice and created the attached patch to
modules/codegen/src of Axis2 0.94. This may not be the best
implementation of <choice> but it is very simple and meets my use
cases. The idea is this. A <choice> is treated just like an
<all> where each enclosed element has minOccurs=0, except that in
the generated code setting any constituent element automatically unsets
all the others. Thus, whatever choice you set last is the choice you
get and you only get one. (The code does not enforce what happens if
you don't set any; this, additional error checking, and accessors to
fully determine the state of what has been chosen, could all be
improved.)
I'm just starting to work with it so have not tested it much yet, but
the generated code looks right to me. It's very simple because it
reuses all the code that is already there and makes just a few mods.
I haven't tried complex nesting cases to see if they all work, and
probably wont' because I only need <choice> of <element>'s,
although in principle any nesting that <all> handles, choice
should too.
I noticed in doing this that none of the particles handle the
<element ref=...> construction. This is somewhat painful, but
livable. If I had more time, I'd try to fix that. It looks like it
might be more complex than this hack due to the way the names are used
in the data structures.
I'd appreciate if you guys would add this to axis2 so I don't have to
patch future releases. If it is not deemed suitable, please let me
know why as perhaps I could fix it, or just fix it!
Thanks,
Chuck
--
Ajith Ranabahu
|
- Re: [Axis2-0.94] WSDL2Java generates bad code for... Chuck Williams
-
