Eran,

maybe I'm wrong, but I think there's a small problem with the Service
interface. The method defined there does not throw any Exception, while
the "common" implementation (this.inMsgCtx =
opctx.getMessageContext(WSDLConstants.MESSAGE_LABEL_IN_VALUE)) does (of
course you can add a try-catch block).

The better solution, should be to remove the throw clause from
OperationContext.getMessageContext() method since this is only a look-up
from a HashMap, which will never throw a AxisFault (furthermore, it will
never throw any exception since HashMap allow both null keys and values).


Regards,
Michele

Eran Chinthaka wrote:
> Ok guys. its implemented and committed to the code base. You may try it now.
> 
> You need to implement org.apache.axis2.Service interface.
> 
> -- Chinthaka
> 
> Davanum Srinivas wrote:
>> +1 from me.
>>
>> On 7/14/06, Deepal Jayasinghe <[EMAIL PROTECTED]> wrote:
>>> so lets go for that , AFAIK we only need to change DependencyManager to
>>> support that.
>>>
>>> Eran Chinthaka wrote:
>>>
>>>> Rodrigo Ruiz wrote:
>>>>
>>>>
>>>>> Mmm, yes of course. But I guess you are talking about a mandatory
>>>>> interface, like Remote. I am talking about an optional one, like
>>>>> LifeCycle. For example:
>>>>>
>>>>> public interface ContextAware {
>>>>>  void setOperationContext(OperationContext ctx);
>>>>> }
>>>>>
>>>>> In this case, only those services interested in having this data will
>>>>> need to implement it. The rest can work just like now.
>>>>>
>>>>> Such an interface would make reflection/introspection unnecessary, and
>>>>> the relationship with Axis2 more explicit.
>>>>>
>>>>>
>>>> Hmm, now it makes sense to me :). I can remember there was a discussion
>>>> on the same topic some time back, on this list, but can not remember
>>>> what happened to it.
>>>>
>>>> What do the others think about this? Can I implement this?
>>>>
>>>> For the time being, lets leave the dependency injection for the existing
>>>> code to work and implement this as well.
>>>>
>>>> Comments ?
>>>>
>>>> -- Chinthaka
>>>>
>>>>
>>>>
>>> -- 
>>> Thanks,
>>> Deepal
>>> ................................................................
>>> ~Future is Open~
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>>> For additional commands, e-mail: [EMAIL PROTECTED]
>>>
>>>
>>
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to