Jörg Walter wrote:
On Monday, 17. February 2003 04:08, Kip Hampton wrote:
Feature:
Add a get_dom() method to the Providers to allow custom Provider authors
to pass in an XML::LibXML DOM document instance.
Yes, +1 for that. But as that means we now have 3 ways of getting our XML, we
should make smart inheritance.
Look at LibXSLT.pm for example - the code used to parse the XML is used all
over AxKit in several places. We should either let get_dom do that work
(parsing the FH or strref if neccessary), and let all others only call
get_dom instead of trying several methods, or provide other helper methods in
case get_dom is not able to exactly replace the current code.
Brilliant idea! +1 from me.
--r
