On Thursday 15 December 2005 21:11, Jörg Walter wrote: > On Saturday, 03. December 2005 18:09, Kjetil Kjernsmo wrote: > > The first turn-rtsub.diff, I think fixes a bug, since $rtsub is > > first assigned a value there, it can't be meaningful as it is. > > Indeed. My test code worked due to that loop, pure coincidence.
OK! > > The second turns most of Moe's commented warns into AxKit::Debug > > statements. I think that's useful, at least they are useful to me > > now that I try to debug. I have assigned levels as I think is nice, > > but I don't know about that, really. > > I don't think this is a good idea, as it is really debugging output > for STL developers, not useful to STL users IMHO. OK, guess so. I think there are still a couple of lines that could be better done as warns, something that users might find useful. I'll review and see what I would find useful as a user... > > > Finally, there's a patch that turns die's into Axkit exceptions. > > That's more elegant, right? > > I agree, mostly. I left the attribute parsing code as-is, as those > are compile-time errors, they usually happen outside of AxKit's > exception handling code. OK. Friendly Tiddely-pom, Kjetil -- Kjetil Kjernsmo Programmer / Astrophysicist / Ski-orienteer / Orienteer / Mountaineer [EMAIL PROTECTED] Homepage: http://www.kjetil.kjernsmo.net/ OpenPGP KeyID: 6A6A0BBC
