Re: XSP.pm comment error

[Matt Sergeant]

On Tuesday, Feb 18, 2003, at 18:40 Europe/London, Michael Nachbaur wrote:

--- /home/nachbaur/.cpan/build/AxKit-1.61/lib/Apache/AxKit/Language/XSP.pm Fri Feb 7 04:22:25 2003
+++ /usr/lib/perl5/site_perl/5.6.0/i386-linux/Apache/AxKit/Language/XSP.pm Tue Feb 18 10:11:02 2003
@@ -8,6 +8,7 @@
use Apache::AxKit::Exception;
use Apache::AxKit::Cache;
use Fcntl;
+use utf8;

use vars qw/@ISA/;

I'm guessing this wasn't meant to be here ;-)

@@ -919,6 +920,13 @@
 package AxKit::XSP::SAXParser;

 use XML::LibXML 1.30;
+BEGIN
+{
+    if($XML::LibXML::VERSION >= 1.53) {
+        require XML::LibXML::Common;
+        XML::LibXML::Common->import( qw/ :libxml :encoding / );
+    }
+}

What's this part in here for? I thought that 1.54 fixed the need for this, and you shouldn't use 1.53 as its buggy as all hell.

@@ -1130,7 +1138,7 @@

 sub __mk_comment_node {
     my ($document, $parent, $text) = @_;
-    my $node = $document->createCommentNode($text);
+    my $node = $document->createComment($text);
     $parent->appendChild($node);
 }

I think that should be backward compatible, and in fact the original probably never worked ;-)

Matt.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]