Re: weird libapreq

[Daisuke Maki]

I've hit that one before. I still don't know what purpose that pnotes 
sub really serves, but you can actually  completely remove that sub and 
things will still work.

--d

Alex Sergeyev wrote:
Seems I know my problems reason - AxKit::Apache uses it's own pnotes that works with one global hash for all requests and Apache::Request knows nothing about it.

That's not good.... 

Maybe should you patch AxKit's pnotes at least for 'apreq' key and store it not in %$PNOTES?

For example - somthing like this:
--- AxKit.pm.old        2003-08-19 21:59:35 +0700
+++ AxKit.pm    2003-08-19 22:02:13 +0700
@@ -1151,6 +1151,7 @@
 sub pnotes {
     my $self = shift;
+    return $self->SUPER::pnotes(@_) if $_[0] && ($_[0] eq 'apreq');
     if ([EMAIL PROTECTED]) {
         return $PNOTES;
     }
I don't know real reason to make such special pnotes in Axkit::Apache - so I can't say that this patch is ok... 

What do you people think about that all?

Alex.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]