Michael Kröll <[EMAIL PROTECTED]> writes: > With that patch, I cannot reproduce the behaviour as described in > http://aspn.activestate.com/ASPN/Mail/Message/perl-xml/1998065 anymore. > The error shows up again with an active "xmlCleanupParser();" line (See > (http://axkit.org/cgi-bin/viewcvs.cgi/XML-LibXML/LibXML.xs.diff?r1=1.166&r2=1.167) > for the changes causing the callback problems). > As I do not know why exactly xmlInitParser(); is needed not to mess up > things, it very likely would be safe not to ommit xmlCleanupParser(), > even if I cannot reproduce the error in a > mod_perl+AxKit+otherXML::LibXML-app environment with ommiting it.
xmlCleanupParser is once called in END(). Maybe this is sufficient,
but since neither of us (or at least I) don't understand it deeply
enough to see all the consequences, I'm quite reluctant to commit it.
> Therefore I looked for another option to solve the problem:
>
> (2) Enable input callbacks for XML::LibXSLT
This looks better to me, but I think can't commit to LibXSLT. I don't
know much of LibXSLT history, but I wonder what was the original
reason for removal of callbacks from LibXSLT? ("callbacks() never
worked and has been removed." doesn't say too much - what's "never
work" supposed to mean?). If there was some reason, you should clarify
that it doesn't apply to your solution. In other words, make sure
re-adding them won't break other things.
From LibXML perspective, you should probably change your patch so that
no LibXSLT internal method uses LibXML_ prefix. (In fact, it is
necessary to make sure that symbols from LibXML and LibXSLT have
different names. Otherwise it might lead to problems on some
platforms, such as OS X/Darwin).
/p
pgp00000.pgp
Description: PGP signature
