Daniel d'Andrada has proposed merging lp:~dandrader/libindicate/plug-leak-gpropcb into lp:libindicate.
Requested reviews: Indicator Applet Developers (indicator-applet-developers) Related bugs: Bug #923629 in indicator-messages (Ubuntu): "indicator-messages-service memory leak" https://bugs.launchpad.net/ubuntu/+source/indicator-messages/+bug/923629 For more details, see: https://code.launchpad.net/~dandrader/libindicate/plug-leak-gpropcb/+merge/92277 Plug leak in get_property_cb It would leak memory whenever an error occurs. -- https://code.launchpad.net/~dandrader/libindicate/plug-leak-gpropcb/+merge/92277 Your team ayatana-commits is subscribed to branch lp:libindicate.
=== modified file 'libindicate/listener.c' --- libindicate/listener.c 2011-09-20 03:17:39 +0000 +++ libindicate/listener.c 2012-02-09 14:14:24 +0000 @@ -954,7 +954,7 @@ if (error != NULL) { g_warning("Unable to get property data: %s", error->message); g_error_free(error); - return; + goto cleanup; } GVariant * value = g_variant_get_child_value(retvalue, 0); @@ -999,6 +999,7 @@ } } + cleanup: if (retvalue != NULL) { g_variant_unref(retvalue); }
_______________________________________________ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp