Review: Disapprove

IMO this is overkill. The original get_version() function clearly intended to 
call lsb_release once and privately cache the result, so the only needed fix is 
to remove the g_free() and to follow the idiom by making get_version() return 
const.
-- 
https://code.launchpad.net/~jjardon/indicator-datetime/fix-844741/+merge/77735
Your team ayatana-commits is subscribed to branch lp:indicator-datetime.

_______________________________________________
Mailing list: https://launchpad.net/~ayatana-commits
Post to     : ayatana-commits@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana-commits
More help   : https://help.launchpad.net/ListHelp

Reply via email to